fix: FORMS-1776 remove role and permission routes

[WalterMoar]

Description

We have API endpoints that allow the creation and updating of roles and permissions. We do not use these endpoints to change the roles and permissions, though, as those actions are done through the Knex migrations (to maintain consistency between environments).

We should remove these API endpoints so that we no longer need to maintain the code.

Acceptance Criteria

• The POST and PUT endpoints for permissions and roles are removed
• The corresponding controller, service, and ORM functions are also removed
• The OpenAPI documentation is removed

Type of Change

fix (a bug fix)

Checklist

• I have read the CONTRIBUTING doc
• I have checked that unit tests pass locally with my changes
• I have run the npm script lint on the frontend and backend
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• I have approval from the product owner for the contribution in this pull request

Further comments

The acceptance criteria listed removing the ORM part of these routes, but it turns out that the database logic is actually in the service.

[usingtechnology]

Nice, that's a good clean up! Hopefully we can catch more of these "dead" APIs.

Are we ignoring duplicated line warnings? It passes the gates so I think it's ok? We can always have a (1/2) sprint later that is dedicated to clearing Sonar warnings... I'll leave it to you for your judgement on this one.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
33.3% Duplication on New Code

See analysis details on SonarQube Cloud

[WalterMoar]

Are we ignoring duplicated line warnings? It passes the gates so I think it's ok? We can always have a (1/2) sprint later that is dedicated to clearing Sonar warnings... I'll leave it to you for your judgement on this one.

I guess we can ignore them for now and see how it works? It's a bit sensitive about duplications, as some of these duplicates were blank lines that I added between functions. Duplicates are tricky, maybe we need to look at them individually as decide case-by-case. And maybe what we think is OK duplication today is something we want to clean up in the future. Plenty of decisions to be made.