Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GEO-1186 Store file with a uuid to prevent overwriting #812

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: GEO-1186 Store file with a uuid to prevent overwriting #812

merged 2 commits into from
Oct 17, 2024

Conversation

jerekm
Copy link
Contributor

@jerekm jerekm commented Oct 16, 2024 •
edited by github-actions bot
Loading

I only changed the name of the file that gets uploaded, nothing else.

Testing steps:

  1. Create new announcement from the Admin Portal and upload a file: https://pay-transparency-pr-812-admin-frontend.apps.silver.devops.gov.bc.ca/announcements
  2. View the announcement form the Frontend: https://pay-transparency-pr-812-frontend.apps.silver.devops.gov.bc.ca/dashboard
  3. Click on the attachment link. It downloads as the link name, and it doesn't download as the filename which was stored.

Note that the announcement preview in the Admin Portal behaves differently that the actual announcement in the frontend.

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@jerekm jerekm changed the title store file with a uuid fix: Store file with a uuid to prevent overwriting Oct 16, 2024
@jerekm jerekm changed the title fix: Store file with a uuid to prevent overwriting fix: GEO-1186 Store file with a uuid to prevent overwriting Oct 16, 2024
@jerekm jerekm marked this pull request as ready for review October 16, 2024 21:36
@jerekm jerekm requested a review from sukanya-rath as a code owner October 16, 2024 21:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Pay Transparency Frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Pay Transparency Backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Pay Transparency admin-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sukanya-rath sukanya-rath merged commit 76690cb into main Oct 17, 2024
34 checks passed
@sukanya-rath sukanya-rath deleted the fix/overwriting-existing-file branch October 17, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukanya-rath sukanya-rath sukanya-rath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerekm @sukanya-rath