fix(FSADT1-1694): change obfuscation to BCSC value (#1387)

* fix(FSADT1-1694): change obfuscation to BCSC value

* chore: Made code reviews

---------

Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca>

backend/src/main/java/ca/bc/gov/app/converters/ForestClientObfuscate.java

@@ -5,7 +5,6 @@
 import com.fasterxml.jackson.databind.JsonSerializer;
 import com.fasterxml.jackson.databind.SerializerProvider;
 import java.io.IOException;
-import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.util.List;
 import java.util.Set;
@@ -88,20 +87,29 @@ public void serialize(
   private String obfuscate(String propName, String propType, Object value) {
     Set<String> roles = toRoles(MDC.get(ApplicationConstant.MDC_USERROLES));
 
-    // Admins and Editors can see with no restrictions
+    // Admins can see the BCSC
     if (
-        roles.contains(ApplicationConstant.ROLE_EDITOR)
-        || roles.contains(ApplicationConstant.ROLE_ADMIN)
-        || roles.contains(ApplicationConstant.ROLE_SUSPEND)
+        CLIENT_IDENTIFICATION.equals(propName)
+        && "BCSC".equals(propType)
+        && roles.contains(ApplicationConstant.ROLE_ADMIN)
     ) {
       return value.toString();
     }
-
+    
     // BC Services card uses a UUID, so we just say it is verified
     if (CLIENT_IDENTIFICATION.equals(propName) && "BCSC".equals(propType)) {
       return "BC Service card verified";
     }
 
+    // Admins and Editors can see with no restrictions
+    if (
+        roles.contains(ApplicationConstant.ROLE_EDITOR)
+        || roles.contains(ApplicationConstant.ROLE_ADMIN)
+        || roles.contains(ApplicationConstant.ROLE_SUSPEND)
+    ) {
+      return value.toString();
+    }
+
     if (CLIENT_IDENTIFICATION.equals(propName) && "BCRE".equals(propType)) {
       return value.toString();
     }