Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable jwks_uri and update bcsc api conditionally #1375

Merged
merged 2 commits into from
Feb 4, 2025
Merged

feat: disable jwks_uri and update bcsc api conditionally #1375

merged 2 commits into from
Feb 4, 2025

Conversation

NithinKuruba
Copy link
Contributor

@NithinKuruba NithinKuruba commented Feb 4, 2025 •
edited
Loading

  1. The jwks_uri parameter is required only if encryption was enabled so removing it for now.
  2. The BCSC API is called only when creating a new or updating BCSC specific fields for existing one.

@NithinKuruba NithinKuruba added the enhancement New feature or request label Feb 4, 2025
@NithinKuruba NithinKuruba changed the title feat: disable jswk_uri and update bcsc api conditionally feat: disable jwks_uri and update bcsc api conditionally Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan 

terraform

Pusher: @NithinKuruba, Action: pull_request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan 

terraform

Pusher: @NithinKuruba, Action: pull_request

@NithinKuruba NithinKuruba merged commit db52d55 into dev Feb 4, 2025
12 checks passed
@NithinKuruba NithinKuruba deleted the SSOTEAM-2180 branch February 4, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcshiftsolutions arcshiftsolutions arcshiftsolutions approved these changes

@thegentlemanphysicist thegentlemanphysicist Awaiting requested review from thegentlemanphysicist thegentlemanphysicist is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NithinKuruba @arcshiftsolutions