Merge pull request #733 from bcnmy/chore/fix-eslint

Chore/fix eslint

README.md

@@ -24,3 +24,9 @@ Other useful commands:
 - `docker compose up -d`: runs the containers in the background without blocking the current terminal sessions.
 - 💡 `docker compose build server`: run this whenever you add a new package to `package.json` or it won't be reflected in the container.
 - `docker compose build --no-cache <service_name>`: build without cache if you suspect caching problems.
+
+## Troubleshooting
+
+### ESLint is not working in VS Code
+- Make sure your Microsoft ESLint extension is the latest version
+- In your VS Code settings make sure `ESLint: Use Flat Config` is enabled

babel.config.js

@@ -1 +1,2 @@
-module.exports = { presets: ['@babel/preset-env'] };
+// eslint-disable-next-line no-undef
+module.exports = { presets: ["@babel/preset-env"] };

eslint.config.mjs

@@ -0,0 +1,11 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+import tseslint from "typescript-eslint";
+
+export default [
+  { files: ["**/*.{js,mjs,cjs,ts}"] },
+  { languageOptions: { globals: globals.browser } },
+  { ignores: ["dist/"] },
+  pluginJs.configs.recommended,
+  ...tseslint.configs.recommended,
+];

jest.config.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-undef
 module.exports = {
   preset: "ts-jest",
   testTimeout: 600000,

package.json

@@ -2,8 +2,6 @@
   "scripts": {
     "commit": "cz",
     "changelog": "npx generate-changelog",
-    "lint": "eslint . --ext .ts",
-    "format": "eslint 'src' --ext .ts --fix",
     "prepare": "husky install",
     "dev": "nodemon",
     "build": "tsc -p .",
@@ -61,6 +59,7 @@
     "viem": "^2.21.28"
   },
   "devDependencies": {
+    "@eslint/js": "^9.13.0",
     "@types/amqplib": "^0.8.2",
     "@types/big.js": "^6.1.5",
     "@types/consolidate": "^0.14.1",
@@ -72,21 +71,23 @@
     "@types/morgan": "^1.9.3",
     "@types/node-cron": "^3.0.4",
     "@types/numeral": "^2.0.2",
-    "@typescript-eslint/eslint-plugin": "^5.40.0",
-    "@typescript-eslint/parser": "^5.40.0",
+    "@typescript-eslint/eslint-plugin": "^8.11.0",
+    "@typescript-eslint/parser": "^8.11.0",
     "babel-jest": "^29.1.2",
     "commitizen": "^4.3.1",
     "cz-conventional-changelog": "^3.3.0",
-    "eslint": "^8.25.0",
-    "eslint-config-airbnb-typescript": "^17.0.0",
+    "eslint": "^9.13.0",
+    "eslint-config-eslint": "^11.0.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-prettier": "^5.1.0",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-prettier": "^5.2.1",
+    "globals": "^15.11.0",
     "jest": "^29.1.2",
     "nodemon": "^3.0.1",
-    "prettier": "^3.1.1",
+    "prettier": "^3.3.3",
     "ts-jest": "^29.0.3",
-    "ts-node": "^10.9.1"
+    "ts-node": "^10.9.1",
+    "typescript-eslint": "^8.11.0"
   },
   "config": {
     "commitizen": {

src/admin-cli/cancel.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import { Command } from "commander";
 import { config } from "dotenv";
 import { privateKeyToAccount } from "viem/accounts";
@@ -86,7 +85,7 @@ async function main() {
     const jsonBody = JSON.parse(responseBody);
     console.log("Parsed JSON response:");
     console.log(JSON.stringify(jsonBody, null, 2));
-  } catch (error) {
+  } catch {
     // If parsing fails, it's not JSON, so we've already logged it as text
     console.log("Response is not JSON");
   }

src/admin-scripts/getRequiredPrefund.ts

@@ -0,0 +1,27 @@
+
+function getRequiredPrefund(userOp: {
+  paymasterAndData: string;
+  callGasLimit: bigint;
+  verificationGasLimit: bigint;
+  preVerificationGas: bigint;
+  maxFeePerGas: bigint;
+}) {
+  const multiplier = userOp.paymasterAndData !== "0x" ? 3n : 1n;
+
+  const requiredGas =
+    userOp.callGasLimit +
+    userOp.verificationGasLimit * multiplier +
+    userOp.preVerificationGas;
+
+  return requiredGas * userOp.maxFeePerGas;
+}
+
+const prefund = getRequiredPrefund({
+  paymasterAndData: "0x",
+  callGasLimit: 651983n,
+  verificationGasLimit: 1459741n,
+  preVerificationGas: 313507n,
+  maxFeePerGas: 15796905452n,
+});
+
+console.log(`Required prefund: ${prefund} wei`);

src/common/cache/redis/RedisCacheService.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-import-module-exports */
 import Redlock, { Lock } from "redlock";
 import Redis from "ioredis";
 import nodeconfig from "config";
@@ -123,7 +122,7 @@ export class RedisCacheService implements ICacheService {
         log.error(error);
       }
     });
-    this.redisClient.on("error", (err: any) => {
+    this.redisClient.on("error", (err: unknown) => {
       log.error(`Redis redisClient Error ${err}`);
     });
   }

src/common/db/dao/TransactionDAO.ts

@@ -79,6 +79,7 @@ export class TransactionDAO implements ITransactionDAO {
   async updateMetaDataAndRelayerDestinationContractDataByTransactionId(
     chainId: number,
     id: string,
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     metaData: any,
     relayerDestinationContractAddress: string,
     relayerDestinationContractName: string,

src/common/db/interface/IUserOperationDAO.ts

@@ -33,6 +33,7 @@ export type FinalUserOperationDataType = {
   actualGasCost: number;
   actualGasUsed: number;
   reason: string;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   logs: any;
 };
 

src/common/db/interface/IUserOperationV07DAO.ts

@@ -36,6 +36,7 @@ export type FinalUserOperationV07DataType = {
   actualGasCost: number;
   actualGasUsed: number;
   reason: string;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   logs: any;
 };
 

src/common/db/mongo/Mongo.ts

@@ -1,5 +1,4 @@
-/* eslint-disable no-await-in-loop */
-/* eslint-disable import/no-import-module-exports */
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import mongoose, { Mongoose } from "mongoose";
 import { config } from "../../../config";
 import { logger } from "../../logger";
@@ -69,7 +68,6 @@ export class Mongo implements IDBService {
     }
   }
 
-  // eslint-disable-next-line class-methods-use-this
   async createIndexes(
     collectionObject: any,
     compoundIndexOne: object,

src/common/db/mongo/interface/IBlockchainTransaction.ts

@@ -38,6 +38,7 @@ export interface IBlockchainTransaction {
   relayerDestinationContractName: string;
   relayerAddress: string;
   walletAddress: string;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   metaData: any;
   resubmitted: boolean;
   creationTime: number;

src/common/db/mongo/models/blockchain-transactions/model.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-empty-object-type */
 import mongoose from "mongoose";
 import { config } from "../../../../../config";
 import { IBlockchainTransaction } from "../../interface/IBlockchainTransaction";

src/common/db/mongo/models/user-operations-state/model.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-empty-object-type */
 import mongoose from "mongoose";
 import { config } from "../../../../../config";
 import { IUserOperationState } from "../../interface";

src/common/db/mongo/models/user-operations/model.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-empty-object-type */
 import mongoose from "mongoose";
 import { config } from "../../../../../config";
 import { IUserOperation, IUserOperationV07 } from "../../interface";

src/common/entrypoint-v7/PackedUserOperation.ts

@@ -40,7 +40,7 @@ export interface PackedUserOperation {
 //  * @returns A Hex string that represents the packed integers.
 //  */
 export function packUint(high128: bigint, low128: bigint): Hex {
-  // eslint-disable-next-line no-bitwise
+   
   const packed = (BigInt(high128) << BigInt(128)) + BigInt(low128);
   return pad(toHex(packed), { size: 32 });
 }
@@ -55,9 +55,9 @@ export function packUint(high128: bigint, low128: bigint): Hex {
 //  */
 export function unpackUint(packed: Hex): [high128: bigint, low128: bigint] {
   const packedNumber = BigInt(fromHex(packed, "bigint"));
-  // eslint-disable-next-line no-bitwise
+   
   const high128 = packedNumber >> BigInt(128);
-  // eslint-disable-next-line no-bitwise
+   
   const low128 = packedNumber & ((BigInt(1) << BigInt(128)) - BigInt(1));
   return [high128, low128];
 }

src/common/gas-price/GasPrice.ts

@@ -1,5 +1,3 @@
-/* eslint-disable prefer-const */
-/* eslint-disable import/no-import-module-exports */
 import { formatUnits, toHex } from "viem";
 import { IEVMAccount } from "../../relayer/account";
 import { ICacheService } from "../cache";

src/common/gas-price/jobs/CacheFees.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-import-module-exports */
 import { CronJob } from "cron";
 import { GasPriceService } from "../GasPrice";
 import { logger } from "../../logger";

src/common/interface/index.ts

@@ -7,9 +7,3 @@ export interface IQueue<TransactionMessageType> {
   consume(onMessageReceived: () => void): Promise<boolean>;
   ack(arg0: ConsumeMessage): Promise<void>;
 }
-
-export interface IRetryPolicy {
-  maxTries: number;
-  shouldRetry: (err: any) => Promise<boolean>;
-  incrementTry: () => void;
-}

src/common/network/EVMNetworkService.ts

@@ -1,8 +1,6 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 /* eslint-disable no-async-promise-executor */
-/* eslint-disable import/no-import-module-exports */
-/* eslint-disable @typescript-eslint/return-await */
-/* eslint-disable new-cap */
-// eslint-disable-next-line max-classes-per-file
+
 import axios from "axios";
 import {
   Hex,
@@ -215,7 +213,6 @@ export class EVMNetworkService
     return await this.sendRpcCall(EthMethodType.GET_TRANSACTION_COUNT, params);
   }
 
-  // eslint-disable-next-line class-methods-use-this
   async sendTransaction(
     rawTransactionData: EVMRawTransactionType,
     account: IEVMAccount,
@@ -333,6 +330,7 @@ export class EVMNetworkService
       return await this.provider.getTransaction({
         hash: transactionHash as `0x${string}`,
       });
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
     } catch (error) {
       return null;
     }
@@ -349,7 +347,6 @@ export class EVMNetworkService
     return await this.sendRpcCall(AlchemyMethodType.SIMULATE_EXECUTION, params);
   }
 
-  // eslint-disable-next-line class-methods-use-this
   async verifySignature(
     address: string,
     message: string,

src/common/network/interface/INetworkService.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { PublicClient, Transaction, TransactionReceipt } from "viem";
 import {
   Type0TransactionGasPriceType,

src/common/notification/NotificationUtil.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { IEVMAccount } from "../../relayer/account";
 import { TransactionType } from "../types";
 import { parseError } from "../utils";

src/common/notification/slack/SlackNotificationService.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-import-module-exports */
 import { WebClient } from "@slack/web-api";
 import { logger } from "../../logger";
 import { ISlackNotificationService } from "../interface";

src/common/queue/BundlerTransactionQueue.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-import-module-exports */
 import amqp, { Channel, ConsumeMessage, Replies } from "amqplib";
 import { config } from "../../config";
 import { logger } from "../logger";

src/common/queue/RetryTransactionHandlerQueue.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-import-module-exports */
 import amqp, { Channel, ConsumeMessage, Replies } from "amqplib";
 import { config } from "../../config";
 import { logger } from "../logger";

src/common/queue/types/index.ts

@@ -10,6 +10,7 @@ export type RetryTransactionQueueData = {
   transactionId: string;
   rawTransaction: EVMRawTransactionType;
   walletAddress: string;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   metaData: any;
   relayerManagerName: string;
 };

src/common/relay-service/BundlerRelayService.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-import-module-exports */
 import { STATUSES } from "../../server/api/shared/middleware";
 import { IQueue } from "../interface";
 import { logger } from "../logger";

src/common/service-manager/index.ts

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-import-module-exports */
-/* eslint-disable no-await-in-loop */
 import { getContract, parseEther } from "viem";
 import { chain } from "lodash";
 import { ENTRY_POINT_ABI } from "entry-point-gas-estimations/dist/gas-estimator/entry-point-v6";
@@ -99,7 +97,6 @@ const retryTransactionQueueMap: {
 } = {};
 const networkServiceMap: Record<number, EVMNetworkService> = {};
 
-// eslint-disable-next-line import/no-mutable-exports
 let statusService: IStatusService;
 
 (async () => {
@@ -305,7 +302,6 @@ let statusService: IStatusService;
     );
     log.info(`Retry transaction service setup for chainId: ${chainId}`);
 
-    // eslint-disable-next-line max-len
     bundlerSimulationServiceMap[chainId] = new BundlerSimulationService(
       networkService,
       gasPriceService,
@@ -407,7 +403,6 @@ let statusService: IStatusService;
     }
   }
 
-  // eslint-disable-next-line no-new
   statusService = new StatusService({
     cacheService,
     networkServiceMap,