chore(cleanup): big cleanup #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup dead code, unused files, broken tests, unnecessary config varaibles etc
TheDivic
added
the
🧹 Chore
fichiokaku
previously approved these changes
Dec 3, 2024
| throw new Error( | ||
| "Slack token or channel name for relayer node is not present in slack configuration", | ||
| ); | ||
| // if (!this.web) { |
There was a problem hiding this comment.
I'm removing the SlackNotification service from the Bundler completely since it's not working anyway and I don't want to send notifications from code but use an external alerting system
Remove the deprecated 'version' tag, update redis to latest & rename the service to 'bundler' as it should be
…e side effects Stuff like funding relayers, validating the config, checking the relayers that we don't want to do in tests for example BREAKING CHANGE: Make sure you never change these variables in production, their default values are the correct ones
Smoke tests atm just check the health of a target bundler instance, e2e tests actually require a private key and funds to perform the full user opration flow. Refer to the docstrings and .env to see how to use them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Context
Type of change
Why are we doing this?
What did we do?
Also some additional smaller changes to the devenv:
nodemonusetsxinstead ofts-nodebecause it transpiles fasterdocker-composefileHow Has This Been Tested?