Refactor/minor things before chain integrations #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can disable the relayer checks independently, for example in smoke tests
…lance in healthchecks We need to enable balance overrides because there are clients who are calling eth_estimateUserOperationGas with empty accounts before actually calling the paymaster for sponsorship. It was previously disabled because it didn't work on the lisk rpc, but now it works. Also don't check relayer balance in healthchecks, just check the master account and assume if it's funded it will fund the relayers. Otherwise we encountered some weird errors that would cause the checks to fail because of problems with relayer balance accounting BREAKING CHANGE: We are not checking the relayer balance in healtchecks any more, by default. It can be enabled in production config (if necessary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Context
Type of change
Why are we doing this?
What did we do?
How Has This Been Tested?