Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMA 379 ABI SVM audit remediations pt 1 #197

Merged
merged 2 commits into from
Feb 14, 2024
Merged

SMA 379 ABI SVM audit remediations pt 1 #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef0053c
natspec fix
Feb 6, 2024
6de8982
bytes32=>uint160=>address conversion for destContract
Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contracts/smart-account/interfaces/modules/ISessionValidationModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ abstract contract ISessionValidationModule {
* @param funcCallData the data for the call.
* is parsed inside the Session Validation Module (SVM)
* @param sessionKeyData SessionKey data, that describes sessionKey permissions
* @param callSpecificData additional data for the call, that is parsed inside the SVM
* @return the Session Key address (public key) that was used to sign the call
*/
function validateSessionParams(
address destinationContract,
Expand Down
4 changes: 2 additions & 2 deletions contracts/smart-account/modules/SessionValidationModules/ABISessionValidationModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ contract ABISessionValidationModule is ISessionValidationModule {
"ABISV Not Execute Selector"
);

address destContract;
uint160 destContract;
uint256 callValue;
bytes calldata data;
assembly {
Expand All @@ -84,7 +84,7 @@ contract ABISessionValidationModule is ISessionValidationModule {

return
_validateSessionParams(
destContract,
address(destContract),
callValue,
data,
_sessionKeyData
Expand Down
Loading