-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update library prefix to beman_
#69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you had the missing context - We don't want to change Beman Standard. But same naming convention needs to additionally be applied when integration into CE (only in CE related PRs).
I will do that, be back with some guidelines. Please drop this PR, as we didn't decided to change the Beman Standard.
Thanks for replying to this PR, noted. So I assume the all the libraries should still be named as Edit: oh crap I mis-typed, I meant |
Not sure what you are asking. We should not change anything to Beman Standard because nobody voted / proposed this at the sync. Beman Standard says: I will clarify the CE naming in #70 . |
Alright, I was reading the meeting note and misunderstood, closing this. |
Examples can be found here: https://github.com/compiler-explorer/infra/pull/1453/files
|
Alright, yeah I understand now. According to: bemanproject/inplace_vector#14 (comment) execution26 might be non-comforming. |
I miss typed. Should be |
In accordance to agreement in weekly sync:
Packed a consistency fix
LIBRARY.NAMES
->LIBRARY.NAME
as it is inconsistent toREPOSITORY.NAME
.