Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library prefix to beman_ #69

Closed
wants to merge 1 commit into from

Conversation

wusatosi
Copy link
Member

In accordance to agreement in weekly sync:

Any beman.<short_name> Beman library name should be converted to beman_<short_name> for filling in the keys in YAML/configs inside the Compiler Explorer infrastructure. The display name from CE UI can be still set to beman.<short_name>, via libs.beman_.name = beman.<short_name>.

Packed a consistency fix LIBRARY.NAMES -> LIBRARY.NAME as it is inconsistent to REPOSITORY.NAME.

Copy link
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you had the missing context - We don't want to change Beman Standard. But same naming convention needs to additionally be applied when integration into CE (only in CE related PRs).

I will do that, be back with some guidelines. Please drop this PR, as we didn't decided to change the Beman Standard.

@neatudarius
Copy link
Member

#70

@wusatosi
Copy link
Member Author

wusatosi commented Nov 27, 2024

Thanks for replying to this PR, noted.

So I assume the all the libraries should still be named as beman_shortname?

Edit: oh crap I mis-typed, I meant beman.shortname

@neatudarius
Copy link
Member

Thanks for replying to this PR, noted.

So I assume the all the libraries should still be named as beman_shortname?

Not sure what you are asking. We should not change anything to Beman Standard because nobody voted / proposed this at the sync.

Beman Standard says:
image
So beman.optional26 it's everywhere in our org. No update from this PR should be kept. AFAIK.

I will clarify the CE naming in #70 .

@wusatosi
Copy link
Member Author

Alright, I was reading the meeting note and misunderstood, closing this.

@wusatosi wusatosi closed this Nov 27, 2024
@neatudarius
Copy link
Member

Examples can be found here: https://github.com/compiler-explorer/infra/pull/1453/files

beman_iterator_interface and beman.iterator_interface are both used in the compiler explorer config (as key in config and value in config). @wusatosi , does this clarify the issue?

@wusatosi
Copy link
Member Author

Examples can be found here: https://github.com/compiler-explorer/infra/pull/1453/files

beman_iterator_interface and beman.iterator_interface are both used in the compiler explorer config (as key in config and value in config). @wusatosi , does this clarify the issue?

Alright, yeah I understand now.

According to: bemanproject/inplace_vector#14 (comment)

execution26 might be non-comforming.

@wusatosi
Copy link
Member Author

Thanks for replying to this PR, noted.

So I assume the all the libraries should still be named as beman_shortname?

Edit: oh crap I mis-typed, I meant beman.shortname

I miss typed. Should be beman.shortname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants