Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BEMAN_STANDARD.md: add REPOSITORY.DISALLOW_GIT_SUBMODULES #75

Conversation

neatudarius
Copy link
Member

@neatudarius neatudarius commented Dec 11, 2024

Update BEMAN_STANDARD.md: add REPOSITORY.DISALLOW_GIT_SUBMODULES

Decision reconfirmed in sync from 09.12.2024. Trigger bemanproject/exemplar#87 (comment).

@wusatosi
Copy link
Member

wusatosi commented Dec 11, 2024

I assume the merging of this PR will mean we rejects package managers like vcpkg as default?

@neatudarius
Copy link
Member Author

I assume the merging of this PR will mean we rejects package managers like vcpkg as default?

It's a recommendation, not a requirement.

@steve-downey
Copy link
Member

steve-downey commented Dec 12, 2024 via email

Copy link
Contributor

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bretbrownjr
Copy link
Contributor

I assume the merging of this PR will mean we rejects package managers like vcpkg as default?

It's safe to say the wording in this section needs edited when we develop standards for how to support package managers like vcpkg, conan, etc.

Hopefully at that point none of vcpkg, conan, or FetchContent needs to be mentioned in individual Beman libraries. Otherwise, we don't really have portable projects.

@neatudarius
Copy link
Member Author

neatudarius commented Dec 12, 2024

I assume the merging of this PR will mean we rejects package managers like vcpkg as default?

It's safe to say the wording in this section needs edited when we develop standards for how to support package managers like vcpkg, conan, etc.

Hopefully at that point none of vcpkg, conan, or FetchContent needs to be mentioned in individual Beman libraries. Otherwise, we don't really have portable projects.

Agree. We can tackle this issue later.

L.E. Linking with #78

Copy link
Member

@camio camio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider decoupling FetchContent and submodule disallowance. Other than that, I just had minor comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants