-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BEMAN_STANDARD.md: add REPOSITORY.DISALLOW_GIT_SUBMODULES #75
Update BEMAN_STANDARD.md: add REPOSITORY.DISALLOW_GIT_SUBMODULES #75
Conversation
I assume the merging of this PR will mean we rejects package managers like vcpkg as default? |
It's a recommendation, not a requirement. |
It's also about how we structure our code, not how we interact with third
party systems and their implementation details.
…On Wed, Dec 11, 2024, 20:22 Darius Neațu ***@***.***> wrote:
I assume the merging of this PR will mean we rejects package managers like
vcpkg as default?
It's a recommendation, not a requirement.
—
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5SCSKLHVYHYPELZTSD2FDQM5AVCNFSM6AAAAABTOP56S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXGUZTQOBRHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's safe to say the wording in this section needs edited when we develop standards for how to support package managers like vcpkg, conan, etc. Hopefully at that point none of vcpkg, conan, or FetchContent needs to be mentioned in individual Beman libraries. Otherwise, we don't really have portable projects. |
Agree. We can tackle this issue later. L.E. Linking with #78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider decoupling FetchContent and submodule disallowance. Other than that, I just had minor comments.
…CMAKE.USE_FETCH_CONTENT
9555a4c
to
79ea387
Compare
Update BEMAN_STANDARD.md: add REPOSITORY.DISALLOW_GIT_SUBMODULES
Decision reconfirmed in sync from 09.12.2024. Trigger bemanproject/exemplar#87 (comment).