Implement Master Server with Initialization Code #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
leejiwon1125
commented
Nov 21, 2023
•
leejiwon1125
commented
- Implement master initialization code which get number of workers from cli.
- Implement worker initialization code which get master IP and port, directories information from cli.
leejiwon1125
changed the title
leejiwon1125
changed the title
|
I realized that there is no need to keep port inforamtion in WorkerMetadata. So we might change it. |
No, it should be remained. It is needed when master sends requests to a worker. |
betarixm
approved these changes
Nov 22, 2023
…se file 3. use InetAddress
… porperly 2. lint
betarixm
approved these changes
Nov 22, 2023
This was
linked to
issues
Nov 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.