fix: strings can't start with "?"

[gerblesh]

This should fix the highlighting of "?" for optional filepaths in the config-file directive

[gerblesh]

This starts to cause issues with config keys such as custom-shader and gtk-custom-css. We could either add these specifically to the grammar or have path_value as a normal value type.

[bezhermoso]

Can you please add some test cases?

[bezhermoso]

============================
Basic Directive - "?" Prefix
============================

custom-shader = "?weird/path/to/shader"
custom-shader = ?weird/path/to/shader

---

(document 
 (directive 
  (basic_directive
   (property)
   (value
    (string))))
 (directive 
  (basic_directive
   (property)
   (value
    (string)))))

^^^ is there a problem in the way this is parsed? According to the docs, only config-file supports paths that may not exist. Tested specifying an non-existent shader file and Ghostty seems just fine.

[gerblesh]

============================
Basic Directive - "?" Prefix
============================

custom-shader = "?weird/path/to/shader"
custom-shader = ?weird/path/to/shader

---

(document 
 (directive 
  (basic_directive
   (property)
   (value
    (string))))
 (directive 
  (basic_directive
   (property)
   (value
    (string)))))

^^^ is there a problem in the way this is parsed? According to the docs, only config-file supports paths that may not exist. Tested specifying an non-existent shader file and Ghostty seems just fine.

hmm, that's odd. It seems like the ? is ignored for everything that accepts path input. Ghostty doesn't seem to be sending warnings when the ? isn't there. Is it worth supporting highlighting the ? then?

[gerblesh]

Could also be a bug, I'm running an unstable git version currently

[bezhermoso]

Until it's officially documented that those properties treat a leading ? as a prefix, I think it's premature to add it to the grammar.

Introducing it in the future doesn't seem like it would be a breaking change as it wouldn't introduce another level to the tree in a way that existing queries might break.

[gerblesh]

Seems like the usage of the ? applies to every directive that accepts some form of filepath(?), I'm inclined to just add the gtk-custom-css and custom-shader directives directly in the grammar

[bezhermoso]

@gerblesh We can generalize it into a path_directive or something.

[gerblesh]

seems like it's also an issue upstream: ghostty-org/ghostty#4509

[gerblesh]

Added some extra tests and squashed the commits, should be able to merge now

[bezhermoso]

Thank you!