Drop async-std crate #179
Merged
Drop async-std crate #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The async-std crate didn't had a release for 1 1/2 years. It also pulls in a lot of dependencies that are usually not needed. The Path::exists() feature of async-std is just using spawn_blocking around the std metadata function and therefore settling on a specific executor and spawning a bunch of threads that might not be needed. Therefore I replaced all uses of async-std with the crates from which async-std is build and that are well maintained.
|
thanks! |
bilelmoussaoui
pushed a commit
that referenced
this pull request
Jan 6, 2024
The async-std crate didn't had a release for 1 1/2 years. It also pulls in a lot of dependencies that are usually not needed. The Path::exists() feature of async-std is just using spawn_blocking around the std metadata function and therefore settling on a specific executor and spawning a bunch of threads that might not be needed. Therefore I replaced all uses of async-std with the crates from which async-std is build and that are well maintained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async-std crate didn't had a release for 1 1/2 years. It also pulls in a lot of dependencies that are usually not needed. The Path::exists() feature of async-std is just using spawn_blocking around the std metadata function and therefore settling on a specific executor and spawning a bunch of threads that might not be needed.
Therefore I replaced all uses of async-std with the crates from which async-std is build and that are well maintained.