Prevent AP setup with too short password #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemenerik
force-pushed
the
rik/pwwarning
branch
from
e2d105f to
cdaf1e4
Compare
ToveRumar
reviewed
Jan 31, 2025
| @@ -235,8 +235,12 @@ static void wifi_ctrl(void* _param) { | |||
| if (rxp.data[1] == 0) { | |||
| wifi_init_sta(ssid, key); | |||
| } else { | |||
| wifi_init_softap(ssid, key); | |||
| } | |||
| if (strlen(key) < 8) { | |||
There was a problem hiding this comment.
If we only check the length so it must be longer than 7, we can never set up an AP with open security.
Inside the wifi_init_softap() the authentication mode is set to open if the password is longer than 0.
I would say we should check the invalid range.
Suggested change
| if (strlen(key) < 8) { | |
| if (0 < strlen(key) && strlen(key) < 8) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the firmware does not attempt to set up an access point if the configured password is shorter than 8 characters. If an invalid password is detected, a warning is logged to inform the user (visible in cfclient console), and the AP setup is skipped.
Fixes #15