#28: Fix buffer overflow bug related to OW memory caching

bitcraze · Feb 6, 2019 · 48b6509 · 48b6509
1 parent 9789506
commit 48b6509
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/memory.c b/src/memory.c
@@ -40,12 +40,12 @@ static bool isInit;
 static int nMemory;
 
 #ifdef BLE
-#define OW_MAX_CACHED 1
+#define OW_MAX_CACHED 4
 static struct {unsigned char address[8]; unsigned char data[122];} owCache[OW_MAX_CACHED];
 
 static void cacheMemory(int nMem)
 {
-  if (nMemory<OW_MAX_CACHED) {
+  if (nMem<OW_MAX_CACHED) {
     owSerialNum(0, owCache[nMem].address, 1);
     ds28e05ReadMemory(0, 0, owCache[nMem].data, 112);
   }
@@ -88,7 +88,7 @@ int owScan()
     {
 #ifdef BLE
       cacheMemory(nMem);
-      if (nMemory>=OW_MAX_CACHED)
+      if (nMem>=OW_MAX_CACHED)
         break;
 #endif
       nMem++;