fix build for ghc 9.8.1 (#386) #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't you think that the changelog entry belongs under it's own header? Otherwise looks fine to me. @parsonsmatt Do you have any suggestions for this PR adding support for GHC 9.8.1 to |
parsonsmatt
requested changes
Feb 6, 2024
changelog.md
Outdated
Comment on lines
7
to
9
| - @arguri | ||
| - [#387](https://github.com/bitemyapp/esqueleto/pull/387) | ||
| - Fix build for ghc 9.8.1 / template-haskell 2.18 |
There was a problem hiding this comment.
Please move this into it's own section of the changelog for this version.
There was a problem hiding this comment.
I hope I got that numbering right.
parsonsmatt
approved these changes
Feb 9, 2024
| @@ -33,7 +33,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| cabal: ["3.8.1.0"] | |||
| ghc: ["8.6.5", "8.8.4", "8.10.4", "9.0.2", "9.2.2", "9.4.5", "9.6.2"] | |||
| ghc: ["8.6.5", "8.8.4", "8.10.4", "9.0.2", "9.2.2", "9.4.5", "9.6.2", "9.8.1"] | |||
There was a problem hiding this comment.
CI is failing due to this issue: haskellari/postgresql-libpq#55
We may be able to fix this by adding an allow-newer flag to a cabal.project:
allow-newer:
postgresql-libpq:Cabal
There was a problem hiding this comment.
Nope, this was the Cabal version that needed to change 😅
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
stylish-haskelland otherwise adhered to the style guide.After submitting your PR: