Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Cycles for 3.6 #412

Merged
merged 8 commits into from
Dec 27, 2024
Merged

Deprecation Cycles for 3.6 #412

merged 8 commits into from
Dec 27, 2024

Conversation

parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Dec 26, 2024

This PR deprecates ilike and removes all terms deprecated prior to 3.5.

Fixes #364
Fixes #288

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

@parsonsmatt parsonsmatt added this to the 3.6 milestone Dec 26, 2024
@parsonsmatt parsonsmatt changed the title Deprecate ilike outside of Postgres Deprecation Cycles for 3.6 Dec 26, 2024
@parsonsmatt parsonsmatt changed the base branch from master to v3.6.0.0 December 27, 2024 18:00
@parsonsmatt parsonsmatt merged commit 3e30a88 into v3.6.0.0 Dec 27, 2024
9 checks passed
parsonsmatt added a commit that referenced this pull request Jan 13, 2025
* Remove `Coercible` abiilty for `SqlExpr`. (#413)

* Remove Coercible

* Remove coercible

* update docs and changelog

* Support upsert with empty updates (#301)

* Support upsert with empty updates

* stylish, changelog link

* clean

* remove focus

* oh no

* update with new api

* tests pass

* Fix distinctOn (#287)

* Fix distinctOn

* lol

* expose

* Deprecation Cycles for 3.6 (#412)

* Deprecate ilike outside of Postgres

* lol

* Deprecation Cycling

* wow okay cool

* oh woops

* Add fixity on question-dot operator (#420)

* Add fixity on question-dot operator

* changelog link

* Deprecate LockingKind constructors (#421)

* Deprecate LockingKind constructors

* changelog

* `HasField` for `SqlExpr (Maybe (Entity a))` joins `Maybe` (#422)

* HasField on SqlExpr (Maybe Entity) joins Maybe

* hmmm that works kinda nicely

* Incorporate changes from the work codebase

* add another test case

* changelog

* wat

* wat

* wat

* 3.6 fixups  (#425)

* Re-export Nullable from ToMaybe

* Fixity on ilike

* lolwhoops

* changelog link

* add toBaseIdMaybe and fromBaseIdMaybe

* start sketching out the sqlcoerce class

* no sqlcoerce yet

* ok for convenience
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confused about when rand removal will happen Delete deprecated terms
1 participant