Drop regex validating URL from intents #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
sunkup
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Why do we have this stripUrl method? It's been added in #247 but I am not sure we actually need it? In what use case does ICSx5 get passed a text as intent which we need to extract the HttpUrl from?
It's been causing issues before ...
Maybe dropping it and then just checking URL validity py parsing the string to a HttpUrl would cause less problems?
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
sunkup
approved these changes
Feb 5, 2025
sunkup
deleted the
500-ics-urls-are-cut-off-when-passed-from-davx5-to-icsx5
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
See #500. URLs are not being stripped correctly.
Short description
Added more characters to the URL regex, and extended test in order to verify that more complex URLs work.
Checklist