Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry sync on DeadObjectException #503

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Feb 12, 2025

Purpose

The DeadObjectException at sync may occur when the remote process dies, or (since Android 14) when IPC (for instance with the calendar provider) is suddenly forbidden because our sync process was demoted from a "service process" to a "cached process". DAVx5 seems to have had the same problem and simply retries the sync.

Short description

  • catch and retry syncing
  • update ical4android

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the bug Something isn't working label Feb 12, 2025
@sunkup sunkup self-assigned this Feb 12, 2025
@sunkup sunkup linked an issue Feb 12, 2025 that may be closed by this pull request
@sunkup sunkup changed the title Retry on DeadObjectException Retry sync on DeadObjectException Feb 12, 2025
@sunkup sunkup requested a review from ArnyminerZ February 12, 2025 13:06
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, looks good. Let's see if this fixes the issue.

@ArnyminerZ ArnyminerZ merged commit 65b5df2 into dev Feb 13, 2025
11 checks passed
@ArnyminerZ ArnyminerZ deleted the 495-periodic-sync-sometimes-fails-silently-with-deadobjectexception branch February 13, 2025 08:38
@AlphaElwedritsch
Copy link

Simple enough, looks good. Let's see if this fixes the issue.

Doesn't fix the issue for me.
Stock pixel OS
App version 2.2.7

@devvv4ever
Copy link
Member

Simple enough, looks good. Let's see if this fixes the issue.

Doesn't fix the issue for me. Stock pixel OS App version 2.2.7

Can you try to install DAVx⁵ please, set it up with any CalDAV server and sync a calendar? Does the scheduled background sync work in this environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Periodic Sync sometimes fails silently with DeadObjectException
4 participants