[PM-15392] Decode Foreign Encodings at User Creation

[BensonB12]

🎟️ Tracking

#4845 (comment)

📔 Objective

Solve the issue of coded foreign characters getting into emails. Was: 'Windmüller' Now: 'Windmüller'

Notes:
Our test are probably in the wrong file. We tried to find the best fitting file we could.

We tried to find the place where the string gets coded to 'ü' and other foreign characters, but we ended up assuming that it was coming from the api call into the controller. Our solution does not work if that is not the case.

Co-authors

• https://github.com/MJebran
• https://github.com/luris26

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-15392
Link: https://bitwarden.atlassian.net/browse/PM-15392

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

[Patrick-Pimentel-Bitwarden]

👍 Reviewed code, lgtm

I didn't follow the auth team's procedure and give the team a chance to review the pr together. We will review it soon.

[trmartin4]

Hello @BensonB12,

First, thank you for your contribution, and for also including tests for your fix.

After reviewing this change, we feel like this is likely not the appropriate fix for the underlying problem. We believe that the scope of #4845 may be larger than just emergency access emails (as you likely identified), but we need to audit the code to assess the proper place for making the encoding change so that it is updated at all points at which a user's email is changed, and also at the point that has the least possible other side effects in the application.

We are also in the process of migrating to a new registration flow, which - if registration is the appropriate place to adjust - would require adding code there as well.

We will be closing this PR and evaluating the fix for #4845 internally, but if you would like to continue iterating on a solution please feel free to re-open.