Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16888] Refactor OrganizationUser status update procedure to use a GuidIdArray parameter and remove JSON parsing logic #5237

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Jan 9, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16888

📔 Objective

When the stored procedure OrganizationUser_SetStatusForUsersById was initially created, it was designed to receive OrganizationUserIds as JSON due to advice at the time against using the GuidIdArray parameter type. Subsequently, to handle account revision updates, the User_BumpAccountRevisionDateByOrganizationUserIdsJson procedure was created.

After further discussion, it has been decided that using the GuidIdArray parameter type is acceptable. As a result, this task aims to:

Drop the stored procedure User_BumpAccountRevisionDateByOrganizationUserIdsJson.

Refactor OrganizationUser_SetStatusForUsersById to accept OrganizationUserIds as a GuidIdArray parameter instead of JSON.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.65%. Comparing base (0153d9d) to head (f60f57d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Console/Repositories/OrganizationUserRepository.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5237      +/-   ##
==========================================
+ Coverage   44.52%   47.65%   +3.12%     
==========================================
  Files        1538     1538              
  Lines       70582    70582              
  Branches     6316     6316              
==========================================
+ Hits        31426    33633    +2207     
+ Misses      37810    35551    -2259     
- Partials     1346     1398      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Logo
Checkmarx One – Scan Summary & Detailsac67035c-6708-44f5-b7aa-12cc1568ae04

Great job, no security vulnerabilities found in this Pull Request

@r-tome r-tome changed the title Refactor OrganizationUser status update procedure to use a GuidIdArra… [PM-16888] Refactor OrganizationUser status update procedure to use a GuidIdArray parameter and remove JSON parsing logic Mar 12, 2025
@r-tome r-tome marked this pull request as ready for review March 12, 2025 12:15
@r-tome r-tome requested review from a team as code owners March 12, 2025 12:15
@r-tome r-tome requested a review from jrmccannon March 12, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants