-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17901] Replaced hard-coded Bitwarden Vault URLs #5458
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5458 +/- ##
==========================================
- Coverage 44.37% 44.37% -0.01%
==========================================
Files 1534 1534
Lines 70499 70504 +5
Branches 6314 6315 +1
==========================================
Hits 31287 31287
- Misses 37869 37874 +5
Partials 1343 1343 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just had a small question/suggestion. Non-blocking.
New Issues (6)Checkmarx found the following issues in this Pull Request
|
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17901
📔 Objective
There were several cases where we had the .com Bitwarden Vault URL hard-coded in our email templates. This PR resolves those according to the requirements in the ticket's "How do we fix it?" section.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes