refactor: make Signal to be type alisa of std::string

std::string is not designed to be inherited form. The destructor of std::string isn't virtual. Signed-off-by: ComixHe <ComixHe1895@outlook.com>
black-desk · Feb 11, 2025 · 95322a7 · 95322a7
1 parent dcef24b
commit 95322a7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/include/ocppi/cli/CommonCLI.hpp b/include/ocppi/cli/CommonCLI.hpp
@@ -31,7 +31,6 @@ struct DeleteOption;
 struct ExecOption;
 struct KillOption;
 struct ListOption;
-class Signal;
 struct StartOption;
 struct StateOption;
 struct GlobalOption;

diff --git a/include/ocppi/runtime/Signal.hpp b/include/ocppi/runtime/Signal.hpp
@@ -2,11 +2,7 @@
 
 #include <string>
 
-namespace ocppi::runtime
-{
-
-class Signal : public std::string {
-        using std::string::string;
-};
+namespace ocppi::runtime {
 
+using Signal = std::string;
 }
diff --git a/include/ocppi/runtime/SpecRuntime.hpp b/include/ocppi/runtime/SpecRuntime.hpp
@@ -10,6 +10,7 @@
 #include "ocppi/runtime/DeleteOption.hpp"
 #include "ocppi/runtime/FeaturesOption.hpp"
 #include "ocppi/runtime/KillOption.hpp"
+#include "ocppi/runtime/Signal.hpp"
 #include "ocppi/runtime/StartOption.hpp"
 #include "ocppi/runtime/StateOption.hpp"
 #include "ocppi/runtime/features/types/Features.hpp"
@@ -24,8 +25,6 @@ namespace state::types
 struct State;
 }
 
-class Signal;
-
 class SpecRuntime {
     public:
         SpecRuntime() = default;