wip: rest of the task view #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacksmithgu
commented
Oct 8, 2024
| listItems.set(item.start, item); | ||
| } | ||
|
|
||
| // In the second list pass, actually construct the list heirarchy. | ||
| for (const item of listItems.values()) { | ||
| listItems.set(item.start, item); |
There was a problem hiding this comment.
note: this does nothing
blacksmithgu
commented
Oct 8, 2024
| @@ -136,20 +136,30 @@ export function markdownImport( | |||
| /////////// | |||
|
|
|||
| // All list items in lists. Start with a simple trivial pass. | |||
| const contentRegex = /^[\t\f\v ]*[\-+\*]\s(\[.\]\s)?/; | |||
There was a problem hiding this comment.
Replacing these with the dataview list matcher which handles various edge cases.
|
Figured out I can just edit contributor PRs directly so will do that to preserve authors better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial PR while I pull out the remaining pieces.