-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: view pages #62
feature: view pages #62
Conversation
Asking this as an interested watcher: if view pages can have a typescript content type for the script, does that mean that the TS compiler is getting bundled? |
@iamrecursion sucrase is bundled in. See here - https://github.com/blacksmithgu/datacore/blob/master/src/utils/javascript.ts#L8-L23 |
Cheers, awesome stuff! |
Apparently I'm allowed to push to feature PRs which is... very interesting. I've pushed some refactors and a I'm wondering if we should adjust this to instead just load a script from a different place (like say, a markdown file) and add the ability for it to set the current file to whatever the active workspace leaf is. That matches closer to my understanding of people's use cases for side panes. |
…er file view (e.g., they can be dragged into the sidebar)
…iguration page's select element
This reverts commit bebb430.
…n the `src/pages` directory
closing this because i plan to delete my fork |
to quote the roadmap:
each view page has its own state consisting of the following properties:
sourceType
: the type of script this view will contain (ex:ts
,js
,jsx
,tsx
...)script
: the actual source code for the scripttitle
: the title, as displayed in the tab/view headercurrentFile
: the configurable path to the current file, so that functions and hooks such asuseCurrentPath
don't chokeall of these are configurable via the view's settings page, which can be accessed via going into the three-dot menu and clicking "View configuration".
a command to create a view page has also been added to the command palette for ease of use.
as always, let me know if i should add or change anything! :)