Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to include transaction CBOR in GET_ACCOUNT_INFO and GET_TRANSACTION #253

Closed
slowbackspace opened this issue Nov 8, 2024 · 2 comments
Closed

Option to include transaction CBOR in GET_ACCOUNT_INFO and GET_TRANSACTION #253

slowbackspace opened this issue Nov 8, 2024 · 2 comments
Assignees
@iccicci
Labels
enhancement New feature or request

Comments

@slowbackspace
Copy link
Contributor

The GET_ACCOUNT_INFO endpoint, when the details parameter is set to txs, provides a paginated list of account transactions. With the addition of transaction CBOR in events from SUBSCRIBE_ADDRESS, extending GET_ACCOUNT_INFO and GET_TRANSACTION to support CBOR data would complete the integration of tx CBOR across all relevant wslink messages
@slowbackspace slowbackspace added the enhancement New feature or request label Nov 8, 2024
@mmahut
Copy link
Member

mmahut commented Nov 8, 2024

Ah, sorry, I did miss this in the original feature request. This is of course needed for any discovery.

This was referenced Nov 19, 2024
Merged
Merged
Merged
@iccicci
Copy link
Contributor

iccicci commented Dec 5, 2024

Done with #270 and #271

@iccicci iccicci closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iccicci iccicci

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mmahut @iccicci @slowbackspace