feat: add optional CBOR representation to GET_TRANSACTION #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
dde7d59 to
09b3697
Compare
iccicci
force-pushed
the
refactor/unify_output_cbor
branch
from
6b5678c to
0b4ce7e
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
09b3697 to
36edc11
Compare
iccicci
force-pushed
the
refactor/unify_output_cbor
branch
from
0b4ce7e to
1a90ca0
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
2 times, most recently
from
7eee599 to
36b7266
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
3 times, most recently
from
99ba285 to
671636e
Compare
slowbackspace
requested changes
Nov 29, 2024
| let promises = []; | ||
|
|
||
| // run thousands of fetchTransactionData | ||
| // (promise limiter concurrency set to 500 by default) | ||
| for (let i = 0; i < 5000; i++) { | ||
| promises.push( | ||
| transactionUtils.fetchTransactionData(`txHash-${i}`).then(data => { | ||
| transactionUtils.fetchTransactionData(`txHash-${i}`, Math.random() > 0.3).then(data => { |
There was a problem hiding this comment.
Suggested change
| transactionUtils.fetchTransactionData(`txHash-${i}`, Math.random() > 0.3).then(data => { | |
| transactionUtils.fetchTransactionData(`txHash-${i}`, true).then(data => { |
Let's just enable it for all calls. Introducing randomness won't make the test more useful and could just make it flaky. We could add another test if it make sense to test cbor=false param, but I think we are good.
There was a problem hiding this comment.
7d3b2b9 should solve this
There was a problem hiding this comment.
👍 please rebase and squash
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
7d3b2b9 to
5f3ab98
Compare
slowbackspace
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #253