test: remove sleep from UNSUBSCRIBE_BLOCK e2e test #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccicci
force-pushed
the
test/unsubscribe_block
branch
from
b28b00c to
a84c54d
Compare
bslabiak
reviewed
Nov 12, 2024
|
|
||
| // ensure the alternative client got the new block while the standard one didn't | ||
| expect(ws1.getSubscriptionMessages().length).equals(0); | ||
| expect(ws2.getSubscriptionMessages().length).equals(1); |
There was a problem hiding this comment.
Can you ws2.close(); to tear down additional ws clinet?
There was a problem hiding this comment.
Nice catch!
309f4ef should solve this
bslabiak
approved these changes
Nov 12, 2024
iccicci
force-pushed
the
test/unsubscribe_block
branch
from
a84c54d to
309f4ef
Compare
iccicci
force-pushed
the
test/unsubscribe_block
branch
from
309f4ef to
eca2363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.