refactor: remove pLimiter code repetition #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,3 +28,6 @@ pLimiter.on('error', error => { | |||
| ratesLimiter.on('error', error => { | |||
| logger.warn(`ratesLimiter error`, error); | |||
| }); | |||
|
|
|||
| export const limiter = <T>(task: () => PromiseLike<T>) => | |||
| pLimiter.add<T>(task, { throwOnTimeout: true }); | |||
There was a problem hiding this comment.
please make sure that the passed options are still configurable
iccicci
force-pushed
the
refactor/readability
branch
from
d7c1eb5 to
92f02ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from when it is used to gather stats,
pLimiteris always used withpLimiter.add(task, { throwOnTimeout: true }).This PR add the
limiterutility to remove this code repetition also increasing a bit the readability.