Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove transformTransactionData code repetition #267

Merged

Conversation

iccicci
Copy link
Contributor

@iccicci iccicci commented Nov 19, 2024

transformTransactionData is always called after a blockfrostAPI.txs call, but not always protected by calls limiter.

This PR adds a fetchTransactionData utility which:

  1. removes the code repetition;
  2. ensures the blockfrostAPI.txs call is protected by calls limiter.

@iccicci iccicci force-pushed the refactor/transformTransactionData_code_repetition branch from 99ead23 to 79ef510 Compare November 21, 2024 14:23
@iccicci iccicci changed the base branch from refactor/pLimiter_code_repetition to master November 21, 2024 14:23
@iccicci iccicci marked this pull request as ready for review November 21, 2024 14:24
@iccicci iccicci force-pushed the refactor/transformTransactionData_code_repetition branch from 5193fd7 to d7634e9 Compare November 22, 2024 10:22
@iccicci iccicci force-pushed the refactor/transformTransactionData_code_repetition branch from a32cc79 to 118d487 Compare November 25, 2024 09:56
@slowbackspace slowbackspace merged commit ffe1baf into master Nov 25, 2024
3 checks passed
@iccicci iccicci deleted the refactor/transformTransactionData_code_repetition branch November 27, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants