test(fv): Add failing tests for if bug
#208
Merged
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are wrapping only some expressions with an `if` clause when we encounter the instruction `enable_side_effects` in the program's SSA. The tests which are being added contain examples where not wrapping the expressions of type function call and assert can cause fomral verification failure.
Syndamia
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are wrapping only some expressions with an
ifclause when we encounter the instructionenable_side_effectsin the program's SSA. Before we thought that only binary expressions requiredifwrapping because they can lead to overflows.The tests which are being added contain examples where not wrapping the expressions of type function call and assert can cause formal verification failure.