Use new GitHub native aarch64 macOS runners #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 92.55% 92.50% -0.05%
==========================================
Files 91 91
Lines 11304 11304
Branches 1581 1581
==========================================
- Hits 10462 10457 -5
- Misses 837 842 +5
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pablogsal
force-pushed
the
new_aarch64_macos
branch
2 times, most recently
from
931b3c3 to
48c1811
Compare
pablogsal
force-pushed
the
new_aarch64_macos
branch
from
48c1811 to
53d879a
Compare
godlygeek
force-pushed
the
new_aarch64_macos
branch
from
fb7dd04 to
e28a853
Compare
pablogsal
force-pushed
the
new_aarch64_macos
branch
from
0b15e51 to
53d879a
Compare
pablogsal
force-pushed
the
new_aarch64_macos
branch
2 times, most recently
from
ed5e8f1 to
e8a50f6
Compare
godlygeek
force-pushed
the
new_aarch64_macos
branch
from
e8a50f6 to
ef623b7
Compare
Now that GitHub has native arm64 macOS runners we can leverage these to build and test our arm64 macOS wheels directly instead of relying on cross-target compilation, which prevented us from exercising the wheels in the CI. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
godlygeek
force-pushed
the
new_aarch64_macos
branch
from
ef623b7 to
15f5c3f
Compare
|
I tested the arm macOS wheels in older macOS versions (Ventura) thanks to @ambv: 3.11: and 3.12: |
|
@godlygeek I think we can be confident that this won't explode in older versions so I think we can proceed with this (you need to approve the PR for it to land) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.