tests: Update snapshots for Textual 0.50 #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a _very_ slight difference in some of the colors, due to a bugfix in Textual 0.50. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 92.55% 92.87% +0.32%
==========================================
Files 91 91
Lines 11304 11134 -170
Branches 1581 2024 +443
==========================================
- Hits 10462 10341 -121
+ Misses 837 793 -44
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The snapshots we've generated using current versions of Textual aren't expected to match anymore on Python 3.7, as Textual dropped support for Python 3.7 in the 0.44 release. However, we'd still like to run our snapshot tests on Python 3.7, to confirm that no unexpected exceptions occur and that the app doesn't crash. So, allow `snap_compare()` to drive the application, but always return `True` on Python 3.7 as long as no exception was raised. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
update_snapshots_for_textual_0.50
branch
from
f99a6c9 to
22aef5d
Compare
pablogsal
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a very slight difference in some of the colors, due to a bugfix in Textual 0.50.