Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve one preposition #566

Merged
merged 1 commit into from
Mar 13, 2024
Merged

docs: improve one preposition #566

merged 1 commit into from
Mar 13, 2024

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Mar 12, 2024

Describe your changes
Used a more natural English idiom.

Testing performed
I read the sentence a number of times. :D

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nedbat!

@godlygeek godlygeek enabled auto-merge (rebase) March 13, 2024 00:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (41248ed) to head (46eed4b).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
+ Coverage   92.55%   92.92%   +0.37%     
==========================================
  Files          91       91              
  Lines       11304    11195     -109     
  Branches     1581     2047     +466     
==========================================
- Hits        10462    10403      -59     
+ Misses        837      792      -45     
+ Partials        5        0       -5     
Flag Coverage Δ
cpp 92.92% <ø> (+6.98%) ⬆️
python_and_cython 92.92% <ø> (-2.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godlygeek godlygeek merged commit f0a145e into bloomberg:main Mar 13, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants