Merge pull request #3 from blue-white-inc/no-cache-proxy

No cache proxy
blue-white-inc · Jul 22, 2022 · 5162c27 · 5162c27
2 parents f0c73c2 + fdbf000
commit 5162c27
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/lib/backends/backend.js b/lib/backends/backend.js
@@ -64,7 +64,6 @@ Backend.prototype.serveAsset = function(asset, req, res) {
         return d.promise;
     }
 
-    res.header('Content-Length', asset.size);
     res.attachment(asset.filename);
 
     return that.getAssetStream(asset)
@@ -73,7 +72,7 @@ Backend.prototype.serveAsset = function(asset, req, res) {
             return Q(stream
                 .on('response', function(res) {
                     delete res.headers['etag'];
-                    res.headers['cache-control'] = 'max-age=7200'
+                    res.headers['cache-control'] = 'max-age=7200';
                 })
                 .pipe(res));
         }

diff --git a/lib/versions.js b/lib/versions.js
@@ -53,18 +53,21 @@ function normalizeVersion(release) {
 
 // Compare two version
 function compareVersions(v1, v2) {
-    if (semver.gt(v1.tag, v2.tag)) {
+    try {
+        if (semver.gt(v1.tag, v2.tag)) {
+            return -1;
+        }
+        if (semver.lt(v1.tag, v2.tag)) {
+            return 1;
+        }
+    } catch(e) {
         return -1;
     }
-    if (semver.lt(v1.tag, v2.tag)) {
-        return 1;
-    }
     return 0;
 }
 
 function Versions(backend) {
     this.backend = backend;
-
 }
 
 // List versions normalized