-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent the deletion of data-lake variables when an input widget is removed #1715
Prevent the deletion of data-lake variables when an input widget is removed #1715
Conversation
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working as expected - nice! :-)
It's probably worth adding deletion capabilities to the data lake variable monitor (so there's at least some way of deleting variables), but that seems potentially out of scope for this PR. @rafaellehmkuhl thoughts on this? It seems somewhat relevant to the changes I suggested over here.
I suppose longer term it would be nice if we could detect whether a variable is being used anywhere else, and delete it automatically when the last reference to it is removed (like garbage collection in a programming language), but I don't expect we have such tight knowledge over everywhere each variable is used at the moment, or a reference count 🤷♂️
It's something we want to have, yes, but it needs the link to source and garbage collection, as you said. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind. Cleaning the cache solved the problem. |
Fixes #1711