❇️ Team member search #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+42
to
+48
| const url = new URL(window.location.href.replace(window.location.search, '')) | ||
|
|
||
| Object.entries({ tab: 'members', ...queryParams }).forEach(([key, value]) => { | ||
| url.searchParams.set(key, value) | ||
| }) | ||
|
|
||
| return url.toString() |
There was a problem hiding this comment.
Did you known ?
Suggested change
| const url = new URL(window.location.href.replace(window.location.search, '')) | |
| Object.entries({ tab: 'members', ...queryParams }).forEach(([key, value]) => { | |
| url.searchParams.set(key, value) | |
| }) | |
| return url.toString() | |
| const url = new URL(window.location.href) | |
| url.search = new URLSearchParams(Object.entries({ tab: 'members', ...queryParams })).toString() | |
| return url.toString() |
There was a problem hiding this comment.
yeah but this loses any already existing params that may already exist in the url, right? we want to keep all params and only add the ones that queryParams adds.
matthieusieben
approved these changes
Mar 5, 2025
arcalinea
temporarily deployed
to
team-member-search - ozone-staging PR #308
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bluesky-social/atproto#3587
This PR adds search feature on team member page and uses the newly available search api in other places where full team member list was being loaded to allow searching by handle/name.
Adds some refactors in usage of getProfiles and fixes formatting issue in user info copy feature.
Screen.Recording.2025-03-03.at.14.07.49.mov