improve info tag contrast #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
bnewbold/label-contrast - ozone-staging PR #315
Render
Destroyed
foysalit
approved these changes
Mar 7, 2025
|
The orange/rust is 5.26:1 (fails WCAG AAA but passes WCAG AA); the light blue/navy is 6.04:1 (also fails WCAG AAA but passes WCAG AA). The WebAIM contrast checker needs RGB converted to hex but has been there for me for over two decades now, heh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not great, but at least a bit better. My web accessibility dev tool thing isn't detecting/confirming if this is enough.
Top is changed colors, bottom is old colors.
This is related to @rahaeli's #310
Maybe even better/clearer would be something like
border-2 border-blue-400? I'm not sure if that is clear enough for any current workflows, and hesitant to make a bigger change w/o mod team feedback.