fix: hide err details

bnb-chain · Jul 24, 2024 · 6566e82 · 6566e82
1 parent b77228d
commit 6566e82
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/restapi/handlers/blob.go b/restapi/handlers/blob.go
@@ -45,7 +45,7 @@ func HandleGetBlobSidecars() func(params blob.GetBlobSidecarsByBlockNumParams) m
 				}
 				sidecars, err = service.BlobSvc.GetBlobSidecarsByRoot(hex.EncodeToString(root), indicesInx)
 				if err != nil {
-					return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalErrorWithError(err))
+					return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalError())
 				}
 			} else {
 				slot, err := util.StringToUint64(blockID)
@@ -54,7 +54,7 @@ func HandleGetBlobSidecars() func(params blob.GetBlobSidecarsByBlockNumParams) m
 				}
 				sidecars, err = service.BlobSvc.GetBlobSidecarsByBlockNumOrSlot(slot, indicesInx)
 				if err != nil {
-					return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalErrorWithError(err))
+					return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalError())
 				}
 			}
 			payload := models.GetBlobSideCarsResponse{
@@ -99,7 +99,7 @@ func HandleGetBSCBlobSidecars() func(params blob.GetBSCBlobSidecarsByBlockNumPar
 			}
 			sidecars, err := service.BlobSvc.GetBlobSidecarsByBlockNumOrSlot(blockNum, nil)
 			if err != nil {
-				return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalErrorWithError(err))
+				return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalError())
 			}
 			// group sidecars by tx hash
 			bscTxSidecars := make(map[string]*models.BSCBlobTxSidecar)

diff --git a/service/error.go b/service/error.go
@@ -26,10 +26,10 @@ func (e Err) Error() string {
 	return fmt.Sprintf("%d: %s", e.Code, e.Message)
 }
 
-func InternalErrorWithError(err error) *models.Error {
+func InternalError() *models.Error {
 	return &models.Error{
 		Code:    500,
-		Message: err.Error(),
+		Message: "internal error",
 	}
 }