fix: use triesInMemory in downloader #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redhdx
previously approved these changes
Jan 29, 2024
bendanzhentan
previously approved these changes
Jan 30, 2024
|
Due to #58 modifying the relevant logic, this PR needs to wait for that PR to be merged before deciding whether to merge. |
|
Close, as we no longer need the triesInMemory parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, our downloader has a hardcoded value of fsMinFullBlocks set to 64, which is half of 128. Since 128 represents TriesInMemory, which is now a configurable option in our geth version, the value of fsMinFullBlocks should change accordingly. For example, if we set TriesInMemory to 32, then the value of fsMinFullBlocks should be 16. We need to resolve this issue.
Rationale
We will store the values of the TriesInMemory configuration item and the fsMinFullBlocks field in the Downloader, and then replace all previous references to the hardcoded fsMinFullBlocks.
Example
none
Changes
Notable changes: