Fix start-deps #61
Merged
Fix start-deps #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Bug I encountered the error "docker-compose command not found" when running `test-integration`. ## Solution Github actions use `docker compose` instead of `docker-compose`. ## Fix Fix both Makefile target `start-deps` and `stop-deps` to check whether the command `docker-compose` (run locally) exists or `docker-compose` (run github actions) exists, and use it to spin up the containes
Lines Of Code
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
I encountered the error "docker-compose command not found" when running
test-integration.Solution
Github actions use
docker composeinstead ofdocker-compose.Fix
Fix both Makefile target
start-depsandstop-depsto check whether the commanddocker-compose(run locally) exists ordocker-compose(run github actions) exists, and use it to spin up the containes