Add a View menu, improve grid plotting #176
Conversation
Updates the gui options, and triggers a replotting of the grid. Some plotting settings are in the Preferences dialog. The View menu and preferences dialog are now kept in sync. Fixed the plot_grid keep_limits functionality, so that the xlim and ylim settings are preserved when replotting.
Uses wall intersection to calculate which cells are outside the wall, and compute a penalty mask that can be used for immersed boundaries. Also improve plotting.
|
The main purpose of all this was to make grid generation issues easier to diagnose visually, and to be able to calculate and plot a |
bendudson
changed the title
Makes plotting in post-processing easier.
Should update the reference grid, but for now ignore variables
Document new features and output variables.
There was a problem hiding this comment.
Thanks @bendudson, looks good to me.
One remaining problem - there is (I think) a bug in Qt.py's --convert feature, which means that on this branch the gui is not working unless PySide2 is installed. The hypnotoad_mainWindow.py file (generated by pyside2-uic) now contains
from PySide2.QtCore import *But the --convert feature only does this:
line = line.replace("from PySide2 import", "from Qt import QtCompat,")
line = line.replace("QtWidgets.QApplication.translate",
"QtCompat.translate")I guess this should be raised as an issue on Qt.py, but the short-term fix would be to edit hypnotoad_mainWindow.py to use the Qt.py equivalent of the PySide2 import (whatever that is). Or we could just require PySide2, but that's probably more work than sticking with Qt.py.
Co-authored-by: John Omotani <john.omotani@ukaea.uk>
Co-authored-by: John Omotani <john.omotani@ukaea.uk>
Same version as now used in Github CI.
Updates the gui options, and triggers a replotting of the grid.
Some plotting settings are in the Preferences dialog. The View menu and preferences dialog are now kept in sync.
Fixed the plot_grid keep_limits functionality, so that the xlim and ylim settings are preserved when replotting.
doc/whats-new.mdwith a summary of the changes