Allow lists to be passed for kwargs in BoutDataset.animate_list() #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if extra kwargs were given, they were passed through to the animation function for all variables being animated. Now a list of values (one per variable) can be passed instead, as for the explicit arguments to animate_list.
|
Once this is merged, I think it's time for a new release, to get the xarray-0.19 and bout-5 compatibility fixes out. Does anyone want to make any other new PRs first? |
|
I'd like to attempt a couple of fixes for #207, but they're not urgent so I don't think they should hold up a new release |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 75.38% 75.34% -0.05%
==========================================
Files 14 14
Lines 2641 2644 +3
Branches 620 622 +2
==========================================
+ Hits 1991 1992 +1
- Misses 422 423 +1
- Partials 228 229 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if extra kwargs were given, they were passed through to the animation function for all variables being animated. Now a list of values (one per variable) can be passed instead, as for the explicit arguments to animate_list.