-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix in case 'dz' was actually 0-dimensional #310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes f49585e "Changes required to load output from a grid-free BOUT.0.nc file, necessary for MMS tests of the differential operators." in case dz was actually zero dimensional, rather than 2-dimensional.
There seem to be test failures unrelated to #309. Is anyone working on these? For example:
|
I also have noticed new errors testing Hermes-3, it seems like my attempt to slice dz.data was too simple a fix.
|
@mrhardman this PR should fix that error. |
I confirm that this fix works for me for the Hermes |
bendudson
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes f49585e "Changes required to load output from a grid-free BOUT.0.nc file, necessary for MMS tests of the differential operators." in case dz was actually zero dimensional, rather than 2-dimensional.
Sorry, I missed that the tests failed on #309, because the final commit by the linter didn't run all the tests, so they weren't listed in the box, and I forgot for a minute that we have lots of pytest tests that should have been there. This PR should fix the test failures.