Try to make splines more periodic #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RectBivariateSpline does not support periodic data, but by including copies on the left and on the right, the spline will be closer to periodic.
Only difference between the two codepaths is that one contains 1/By and the other Rmaj / By. setting Rmaj to one unifies them.
In some cases it is easier to calculate all components at once Adding a new function can be far more efficient for these cases.
ZedThree
reviewed
Nov 29, 2024
| # Repeat the final point in y since periodic in y | ||
| R_ext = np.concatenate((R, np.reshape(R[:, 0], (nx, 1))), axis=1) | ||
| Z_ext = np.concatenate((Z, np.reshape(Z[:, 0], (nx, 1))), axis=1) | ||
| R_ext = np.concatenate((R, R, R), axis=1) |
There was a problem hiding this comment.
Comment above probably wants changing!
ZedThree
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RectBivariateSpline does not support periodic data, but by including copies on the left and on the right, the spline will be closer to periodic.