Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim whitespaces #402

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Trim whitespaces #402

merged 1 commit into from
Feb 25, 2025

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Feb 25, 2025

Closes #309

Proposed Changes

Feb-25-2025 12-45-53

This doesn't work for FEEL editors:
Feb-25-2025 12-46-30

Follow up to #401

You can test this works via:

npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel -l bpmn-io/properties-panel#trim-whitespaces

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@barmac
Copy link
Member

barmac commented Feb 25, 2025

This PR may indirectly fix camunda/camunda-modeler#4818 as well.

@abdul99ahad abdul99ahad marked this pull request as draft February 25, 2025 15:15
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Feb 25, 2025
@abdul99ahad abdul99ahad marked this pull request as ready for review February 25, 2025 18:31
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 25, 2025
@abdul99ahad abdul99ahad requested a review from nikku February 25, 2025 18:31
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, for me.

@abdul99ahad abdul99ahad merged commit 4438da6 into main Feb 25, 2025
10 of 11 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 25, 2025
@abdul99ahad abdul99ahad deleted the trim-whitespaces branch February 25, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-trim leading whitespaces when pasting into property fields
3 participants