chore: remove package for polyfill #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency of `paragonie/random_compat` doesn't seem useful anymore. I guess it was useful for PHP less than 7. See https://github.com/paragonie/random_compat/blob/master/lib/random.php#L47-L49
bpolaszek
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Probably not cleaned up since f267a85#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency of
paragonie/random_compatdoesn't seem useful anymore.I guess it was useful for PHP less than 7.
See https://github.com/paragonie/random_compat/blob/master/lib/random.php#L47-L49