cmd/errtrace: Best-effort detection of tty stdin using char device #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested the following cases:
And it worked fine on Linux, MacOS and Windows. |
prashantv
force-pushed
the
prashant/stdin-check-tty
branch
from
9d4abff to
abbc81d
Compare
Follow-up to #78 and #82. When stdin is implicitly used, we wait for 200ms for input before printing a message to stderr to notify the user that we're reading from stdin to avoid confusion. This added some complexity in the read path, as well as the testing because of the background goroutine that waits for a timeout before printing to stderr. This is an alternative approach that does a best-effort detection of a TTY by checking if stdin is a character device.
prashantv
force-pushed
the
prashant/stdin-check-tty
branch
from
abbc81d to
42bfb99
Compare
abhinav
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #78 and #82.
When stdin is implicitly used, we wait for 200ms for input before printing a message to stderr to notify the user that we're reading from stdin to avoid confusion. This added some complexity in the read path, as well as the testing because of the background goroutine that waits for a timeout before printing to stderr.
This is an alternative approach that does a best-effort detection of a TTY by checking if stdin is a character device.