cmd/errtrace: Add toolexec mode for automatic rewriting #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use TOOLEXEC_IMPORTPATH to determine if we're running in toolexec mode. In toolexec mode, all go tool executions are intercepted, though only compile commands interacting with .go files are modified. Only .go files that import errtrace are rewritten to a temporary file and passed to compile instead of the original path.
prashantv
force-pushed
the
prashant/toolexec-1
branch
from
0084164 to
4ffa914
Compare
abhinav
approved these changes
Feb 18, 2024
* main: toolexec rewrite expected * p1: no import, no rewrite * p2: already wrapped * p3: toolexec rewrite expected
prashantv
force-pushed
the
prashant/toolexec-1
branch
from
37b0900 to
d2760af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
The go command supports
-toolexecto intercept calls to the underlying compile/link tools.By intercepting compile commands, we can modify the .go files passed to it to rewrite as
part of the build process.
There are some limitations: we can't add new dependencies to a package, so this initial version
only rewrites packages that already import errtrace, acting as an opt-in to rewriting.
We automatically determine if we're in toolexec mode based on the arguments/environment.
This simplifies usage,