cmd/errtrace: Uniquely identify the binary for toolexec version #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toolexec version should be bumped on any change to the code rewriting. Doing this manually is error-prone, so instead, use a string that uniquely identifies the errtrace binary. Note that every time this version changes, it means the build cache can't be used so it's important to use a stable value. We default to the git SHA in the debug build info (vcs.revision) if the binary is build from a clean state (vcs.modified=false). Otherwise, we use the MD5 of the binary being executed. This is more expensive than the SHA to compute, so we prefer the SHA.
prashantv
force-pushed
the
prashant/toolexec-version
branch
from
7566df7 to
05c6d7f
Compare
abhinav
approved these changes
Feb 18, 2024
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolexec version should be bumped on any change to the code rewriting. Doing this manually is error-prone, so instead, use a string that uniquely identifies the errtrace binary. Note that every time this version changes, it means the build cache can't be used so it's important to use a stable value.
We default to the git SHA in the debug build info (vcs.revision) if the binary is build from a clean state (vcs.modified=false).
Otherwise, we use the MD5 of the binary being executed. This is more expensive than the SHA to compute, so we prefer the SHA.